Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove spatial subset selection from Mosviz image viewer #2102

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

rosteen
Copy link
Collaborator

@rosteen rosteen commented Mar 20, 2023

Spatial subsets were not used for anything in Mosviz, and selecting them actually created problems. Removing the option to select them for now - we can always add them back later if desired.

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't see spatial subset mentioned in official example notebooks. Thanks!

@pllim pllim added this to the 3.4 milestone Mar 20, 2023
@pllim
Copy link
Contributor

pllim commented Mar 20, 2023

I added 0877c09 on main to ignore the deprecation warning. Please rebase.

Copy link
Collaborator

@duytnguyendtn duytnguyendtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough! Sidesteps a few known pain points as well :)

@rosteen rosteen force-pushed the subsets-more-like-gonesets branch from f079e62 to 201fda9 Compare March 20, 2023 21:02
@rosteen rosteen merged commit f8b4e6e into spacetelescope:main Mar 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants