Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

swap zoom x/y range #2212

Merged
merged 1 commit into from
May 24, 2023
Merged

swap zoom x/y range #2212

merged 1 commit into from
May 24, 2023

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented May 23, 2023

Description

This pull request swaps the horizontal/vertical x/y-range zoom tool icons in response to #2206 (comment)

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added the trivial Only needs one approval instead of two label May 23, 2023
@kecnry kecnry added this to the 3.5 milestone May 23, 2023
@kecnry kecnry marked this pull request as ready for review May 23, 2023 18:28
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b919c93) 91.63% compared to head (ac1e229) 91.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2212   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         148      148           
  Lines       16409    16409           
=======================================
  Hits        15037    15037           
  Misses       1372     1372           

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@duytnguyendtn duytnguyendtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So intuitive to me, my muscle memory couldn't tell it changed! Thanks

@kecnry kecnry merged commit 8bdad10 into spacetelescope:main May 24, 2023
@kecnry kecnry deleted the icon-swap branch May 24, 2023 15:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants