Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add vmin and vmax lines to histogram #2301

Merged
merged 8 commits into from
Jul 25, 2023

Conversation

javerbukh
Copy link
Contributor

@javerbukh javerbukh commented Jul 18, 2023

Description

This pull request is to address point 4 of this comment #2097 (comment)

Before
image

After
EDIT: Removed original image, here is the latest:
image

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Add vmin and vmax lines to plot options histogram. [2301]

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@javerbukh javerbukh added this to the 3.6 milestone Jul 18, 2023
@javerbukh javerbukh added UI/UX😍 plugin Label for plugins common to multiple configurations labels Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (0f3f4f6) 90.95% compared to head (0692da9) 90.99%.

❗ Current head 0692da9 differs from pull request most recent head 3d70288. Consider uploading reports for the commit 3d70288 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2301      +/-   ##
==========================================
+ Coverage   90.95%   90.99%   +0.03%     
==========================================
  Files         152      152              
  Lines       17198    17274      +76     
==========================================
+ Hits        15642    15718      +76     
  Misses       1556     1556              
Files Changed Coverage Δ
...nfigs/default/plugins/plot_options/plot_options.py 95.08% <100.00%> (+0.41%) ⬆️
...lt/plugins/plot_options/tests/test_plot_options.py 100.00% <100.00%> (ø)
jdaviz/core/marks.py 90.76% <100.00%> (+0.14%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +603 to +604
self._remove_histogram_marks()
self._add_histogram_marks()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just modify the position of the existing marks instead of destroying and creating new ones?

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to defer optimizing updating the mark until the effort to use the plot subcomponent (#2254).

Copy link
Collaborator

@duytnguyendtn duytnguyendtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was promised a 30 line code review, this is over double what I was promised! 😉

I find the histogram marks to be quite responsive and the code straightforward to read. Thanks!

@kecnry
Copy link
Member

kecnry commented Jul 25, 2023

(Probably worth a squash & merge once the change log is added)

@javerbukh javerbukh merged commit 0b268b9 into spacetelescope:main Jul 25, 2023
@javerbukh javerbukh deleted the min-max-histogram branch July 25, 2023 16:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
plugin Label for plugins common to multiple configurations Ready for final review UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants