Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TST: Python 3.12 #2473

Merged
merged 1 commit into from
Sep 29, 2023
Merged

TST: Python 3.12 #2473

merged 1 commit into from
Sep 29, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Sep 21, 2023

Description

This pull request is to see how much work is needed for CI to run successfully with Python 3.12 (devdeps).

Blocked by:

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@pllim pllim added this to the 3.7 milestone Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...imviz/plugins/aper_phot_simple/aper_phot_simple.py 92.36% <100.00%> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@pllim pllim modified the milestones: 3.7, 3.8 Sep 21, 2023
@pllim

This comment was marked as resolved.

@jarrodmillman
Copy link

We should have a 0.22.0rc0 out today with py312 wheel!! If that looks good, we will release 0.22.0 on Friday or Monday morning.

@pllim pllim force-pushed the py312-devdeps branch 4 times, most recently from 5a3648a to 333247a Compare September 28, 2023 19:51
TST: Ignore DeprecationWarning in Python 3.12 from dateutil that got pulled in by asdf.
@pllim pllim modified the milestones: 3.8, 3.7.1 Sep 28, 2023
@pllim pllim added 💤 backport-v3.7.x on-merge: backport to v3.7.x trivial Only needs one approval instead of two labels Sep 28, 2023
@pllim
Copy link
Contributor Author

pllim commented Sep 28, 2023

I think we should backport this. The compatibility patch isn't big and this way, we don't have to scramble for a new feature release just for Python 3.12 support.

I will update branch protection after merge. The checks here will show required 2 jobs not running because I renamed them.

@pllim pllim marked this pull request as ready for review September 28, 2023 21:59
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim pllim merged commit 4653883 into spacetelescope:main Sep 29, 2023
@pllim pllim deleted the py312-devdeps branch September 29, 2023 16:53
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Sep 29, 2023
pllim added a commit that referenced this pull request Sep 29, 2023
…3-on-v3.7.x

Backport PR #2473 on branch v3.7.x (TST: Python 3.12)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
testing trivial Only needs one approval instead of two 💤 backport-v3.7.x on-merge: backport to v3.7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants