Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Have viewer settings come before layer settings in Plot Options #2543

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

javerbukh
Copy link
Contributor

@javerbukh javerbukh commented Nov 1, 2023

Description

This pull request puts viewer settings before layer settings.

Imviz

image

Cubeviz

image

Specviz

image

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.
  • Reorder viewer and layer settings in the plot options plugin. [2543]

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@javerbukh javerbukh added this to the 3.8 milestone Nov 1, 2023
@javerbukh javerbukh added UI/UX😍 plugin Label for plugins common to multiple configurations labels Nov 1, 2023
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking we might want to get rid of the "Viewer/layer options" headers once the final design is realized... but I see how they help in the meantime as we transition towards that.

@javerbukh javerbukh added the trivial Only needs one approval instead of two label Nov 1, 2023
@javerbukh javerbukh enabled auto-merge (squash) November 1, 2023 15:32
@javerbukh javerbukh merged commit d033439 into spacetelescope:main Nov 1, 2023
15 of 16 checks passed
@javerbukh javerbukh deleted the reorder-plot-options branch November 1, 2023 18:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants