Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

save collapsed spectrum to FITS #2586

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

cshanahan1
Copy link
Contributor

@cshanahan1 cshanahan1 commented Dec 1, 2023

This PR adds functionality to the cubeviz collapse plugin to save an output FITS file.

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this won't stay like this for long and we can prioritize a more general solution soon, but until then this looks good - thanks!

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (bd312bd) 91.51% compared to head (6e1c863) 91.52%.

Files Patch % Lines
...plugins/spectral_extraction/spectral_extraction.py 86.48% 5 Missing ⚠️
...daviz/configs/default/plugins/collapse/collapse.py 86.48% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2586    +/-   ##
========================================
  Coverage   91.51%   91.52%            
========================================
  Files         161      161            
  Lines       19596    19724   +128     
========================================
+ Hits        17934    18052   +118     
- Misses       1662     1672    +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@javerbukh javerbukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for a while and works well! If you can show a snackbar message when the file already exists and the user presses "save as fits", this will be ready for merge.

@cshanahan1
Copy link
Contributor Author

i added the overwrite overlay to the save button if the file already exists

@cshanahan1 cshanahan1 force-pushed the export_cubeviz_spectrum branch 3 times, most recently from fa18eb1 to 5c3ed3b Compare December 7, 2023 01:56
@cshanahan1 cshanahan1 force-pushed the export_cubeviz_spectrum branch from 33302c5 to 6e1c863 Compare December 7, 2023 14:47
@cshanahan1 cshanahan1 merged commit b8c1098 into spacetelescope:main Dec 7, 2023
13 of 14 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants