-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
save collapsed spectrum to FITS #2586
save collapsed spectrum to FITS #2586
Conversation
jdaviz/configs/cubeviz/plugins/spectral_extraction/spectral_extraction.vue
Outdated
Show resolved
Hide resolved
jdaviz/configs/cubeviz/plugins/spectral_extraction/spectral_extraction.py
Outdated
Show resolved
Hide resolved
jdaviz/configs/cubeviz/plugins/spectral_extraction/spectral_extraction.vue
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully this won't stay like this for long and we can prioritize a more general solution soon, but until then this looks good - thanks!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2586 +/- ##
========================================
Coverage 91.51% 91.52%
========================================
Files 161 161
Lines 19596 19724 +128
========================================
+ Hits 17934 18052 +118
- Misses 1662 1672 +10 ☔ View full report in Codecov by Sentry. |
jdaviz/configs/cubeviz/plugins/spectral_extraction/spectral_extraction.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested for a while and works well! If you can show a snackbar message when the file already exists and the user presses "save as fits", this will be ready for merge.
i added the overwrite overlay to the save button if the file already exists |
fa18eb1
to
5c3ed3b
Compare
33302c5
to
6e1c863
Compare
This PR adds functionality to the cubeviz collapse plugin to save an output FITS file.