Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

BUG: Fix Line Profile when there is NaN #2594

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Dec 6, 2023

Description

This pull request is to address plotting line profiles when NaN is present. With this patch, the plot should now look like this instead of a blank plot:

Screenshot 2023-12-06 121646

I still see this in the browser dev console but does not seem to break Imviz:

Screenshot 2023-12-06 121622

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

@pllim pllim added bug Something isn't working 💤backport-v3.8.x on-merge: backport to v3.8.x labels Dec 6, 2023
@pllim pllim added this to the 3.8.1 milestone Dec 6, 2023
@github-actions github-actions bot added the imviz label Dec 6, 2023
@pllim pllim mentioned this pull request Dec 6, 2023
9 tasks
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a86e698) 91.53% compared to head (5bc1855) 91.53%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2594   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files         161      161           
  Lines       19602    19618   +16     
=======================================
+ Hits        17942    17957   +15     
- Misses       1660     1661    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
@pllim pllim marked this pull request as ready for review December 6, 2023 20:10
@pllim pllim merged commit d1baddc into spacetelescope:main Dec 7, 2023
17 of 18 checks passed
Copy link

lumberbot-app bot commented Dec 7, 2023

Something went wrong ... Please have a look at my logs.

It seems that the branch you are trying to backport to does not exist.

@pllim pllim deleted the nan-desuka-2 branch December 7, 2023 22:03
@pllim
Copy link
Contributor Author

pllim commented Dec 7, 2023

Thanks for the reviews!

@meeseeksdev backport to v3.8.x

meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Dec 7, 2023
pllim added a commit that referenced this pull request Dec 7, 2023
…4-on-v3.8.x

Backport PR #2594 on branch v3.8.x (BUG: Fix Line Profile when there is NaN)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working imviz Ready for final review 💤backport-v3.8.x on-merge: backport to v3.8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants