-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
BUG: Fix Line Profile when there is NaN #2594
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
added
bug
Something isn't working
💤backport-v3.8.x
on-merge: backport to v3.8.x
labels
Dec 6, 2023
9 tasks
kecnry
reviewed
Dec 6, 2023
jdaviz/configs/imviz/plugins/line_profile_xy/line_profile_xy.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2594 +/- ##
=======================================
Coverage 91.53% 91.53%
=======================================
Files 161 161
Lines 19602 19618 +16
=======================================
+ Hits 17942 17957 +15
- Misses 1660 1661 +1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
pllim
requested review from
rosteen,
javerbukh,
bmorris3,
haticekaratay and
cshanahan1
as code owners
December 6, 2023 20:10
kecnry
approved these changes
Dec 7, 2023
cshanahan1
approved these changes
Dec 7, 2023
Something went wrong ... Please have a look at my logs. It seems that the branch you are trying to backport to does not exist. |
Thanks for the reviews! @meeseeksdev backport to v3.8.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jdaviz
that referenced
this pull request
Dec 7, 2023
pllim
added a commit
that referenced
this pull request
Dec 7, 2023
…4-on-v3.8.x Backport PR #2594 on branch v3.8.x (BUG: Fix Line Profile when there is NaN)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
bug
Something isn't working
imviz
Ready for final review
💤backport-v3.8.x
on-merge: backport to v3.8.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to address plotting line profiles when NaN is present. With this patch, the plot should now look like this instead of a blank plot:
I still see this in the browser dev console but does not seem to break Imviz:
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.