Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

expose spatial subset opacity in plot options #2663

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Jan 17, 2024

Description

This pull request exposes the spatial subset opacity in the plot options (UI and API).

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 3.9 milestone Jan 17, 2024
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Jan 17, 2024
@kecnry kecnry force-pushed the plot-options-subset-opacity branch from f8c5295 to d9c5ba7 Compare January 17, 2024 18:39
@kecnry kecnry added the trivial Only needs one approval instead of two label Jan 17, 2024
@kecnry kecnry marked this pull request as ready for review January 18, 2024 15:52
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Cubeviz, works. Seems slightly laggy or coarse-grained or something, but I think it's ok. Also surprised me that it isn't totally opaque at the highest slider setting, but I don't see why you would want that anyway.

@kecnry kecnry merged commit 5c69d28 into spacetelescope:main Jan 18, 2024
16 of 17 checks passed
@kecnry kecnry deleted the plot-options-subset-opacity branch January 18, 2024 18:20
gibsongreen pushed a commit to gibsongreen/jdaviz that referenced this pull request Feb 12, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants