Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add API to access mask cube #2718

Closed
wants to merge 1 commit into from

Conversation

javerbukh
Copy link
Contributor

@javerbukh javerbukh commented Feb 21, 2024

Description

This PR adds API to the helper class to access the mask cube in cubeviz if it is loaded, extending on similar logic for flux/uncertainty cubes introduced in #2646.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@github-actions github-actions bot added cubeviz plugin Label for plugins common to multiple configurations labels Feb 21, 2024
@javerbukh javerbukh added this to the 3.9 milestone Feb 21, 2024
@kecnry kecnry added the no-changelog-entry-needed changelog bot directive label Feb 21, 2024
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me thanks! I think we should avoid using this too much internally since we might eventually want to support multiple masks - but this is useful for now in the same way as in #2646 and is nice to make that complete for all three cube-types.

@javerbukh javerbukh mentioned this pull request Mar 27, 2024
11 tasks
@gibsongreen gibsongreen modified the milestones: 3.9, 3.10 Apr 5, 2024
@bmorris3 bmorris3 modified the milestones: 3.10, 3.11 May 3, 2024
@rosteen rosteen modified the milestones: 3.11, 4.0, 4.1 Oct 17, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cubeviz no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants