Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix broken div in export plugin #2772

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Mar 28, 2024

Description

This pull request removes and unused/closed div, and fixes indentation inadvertently introduce in #2760.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added the trivial Only needs one approval instead of two label Mar 28, 2024
@kecnry kecnry added this to the 3.10 milestone Mar 28, 2024
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Mar 28, 2024
@kecnry kecnry marked this pull request as ready for review March 28, 2024 12:43
@kecnry kecnry mentioned this pull request Mar 28, 2024
9 tasks
@kecnry kecnry modified the milestones: 3.10, 3.9 Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (f1ba4a6) to head (9031a15).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2772      +/-   ##
==========================================
+ Coverage   88.72%   88.80%   +0.08%     
==========================================
  Files         110      110              
  Lines       16353    16394      +41     
==========================================
+ Hits        14509    14559      +50     
+ Misses       1844     1835       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@haticekaratay haticekaratay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick patch.

@kecnry kecnry merged commit 90b09b0 into spacetelescope:main Mar 28, 2024
17 checks passed
@kecnry kecnry deleted the fix-export-div branch March 28, 2024 14:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants