-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Consolidate filename normalization for exports #2782
Conversation
Looks like one test case broke:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2782 +/- ##
==========================================
+ Coverage 88.72% 88.82% +0.09%
==========================================
Files 110 110
Lines 16353 16425 +72
==========================================
+ Hits 14509 14589 +80
+ Misses 1844 1836 -8 ☔ View full report in Codecov by Sentry. |
@pllim I fixed that test, the remaining failure is a failed remote data download, not anything to do with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me and also am glad to see the filetype handling reusable rather than copy-pasted everywhere. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clean up. Thanks!
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
This consolidates the filename logic for exporting to fix the standalone case for all export types, not just movies. I wasn't sure whether to put the changelog in with the other Export stuff or in Bug Fixes, since I think the standalone issue was present in 3.8.