Disable export for unsupported units #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2784 +/- ##
==========================================
+ Coverage 88.72% 88.88% +0.15%
==========================================
Files 110 110
Lines 16353 16505 +152
==========================================
+ Hits 14509 14670 +161
+ Misses 1844 1835 -9 ☔ View full report in Codecov by Sentry. |
kecnry
approved these changes
Apr 4, 2024
haticekaratay
force-pushed
the
units-export
branch
from
e49ca6d to
eebf2e4
Compare
haticekaratay
requested review from
rosteen,
javerbukh,
pllim,
bmorris3,
cshanahan1 and
gibsongreen
as code owners
cshanahan1
reviewed
Apr 4, 2024
cshanahan1
approved these changes
Apr 4, 2024
kecnry
reviewed
Apr 4, 2024
| if self.dataset.selected_obj.meta.get("Plugin", None) is None: | ||
| # NOTE: should not be a valid choice due to dataset filters, but we'll include | ||
| # another check here. | ||
| self.data_invalid_msg = "Data export is only available for plugin generated data." | ||
| elif not isinstance(self.dataset.selected_obj, (Spectrum1D, CCDData)): | ||
| self.data_invalid_msg = "Export is not implemented for this type of data" | ||
| elif data_unit == u.Unit('DN/s'): | ||
| elif (data_unit := self.dataset.selected_obj.unit) == u.Unit('DN/s'): |
There was a problem hiding this comment.
Yes. The Walrus! :)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request disables writing data products to FITS files due to unsupported DN/s units in Astroquery's internal.
Fixes #
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.