BUG: Fix random flip in WCS orientation #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
added
bug
pllim
requested review from
rosteen,
javerbukh,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
rosteen
approved these changes
Apr 15, 2024
bmorris3
approved these changes
Apr 16, 2024
Comment on lines
+170
to
+181
| x_bl, y_bl = self.reference_data.coords.world_to_pixel(world_bottom_left) | ||
| x_tr, y_tr = self.reference_data.coords.world_to_pixel(world_top_right) | ||
|
|
||
| x_pix_min = min(x_bl, x_tr) | ||
| x_pix_max = max(x_bl, x_tr) | ||
| y_pix_min = min(y_bl, y_tr) | ||
| y_pix_max = max(y_bl, y_tr) | ||
|
|
||
| x_min = min(x_min, x_pix_min - 0.5) | ||
| x_max = max(x_max, x_pix_max + 0.5) | ||
| y_min = min(y_min, y_pix_min - 0.5) | ||
| y_max = max(y_max, y_pix_max + 0.5) |
There was a problem hiding this comment.
I really hoped this was all it needed, glad to see that it is!
This comment was marked as resolved.
This comment was marked as resolved.
pllim
added a commit
to pllim/jdaviz
that referenced
this pull request
Apr 16, 2024
* BUG: Fix random flip in WCS orientation * TST: Update test results (cherry picked from commit 620ccfe)
gibsongreen
pushed a commit
to gibsongreen/jdaviz
that referenced
this pull request
Apr 16, 2024
* BUG: Fix random flip in WCS orientation * TST: Update test results
9 tasks
pllim
added a commit
that referenced
this pull request
Apr 16, 2024
rosteen
pushed a commit
to rosteen/jdaviz
that referenced
this pull request
Apr 18, 2024
* BUG: Fix random flip in WCS orientation * TST: Update test results
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to hopefully address the problem of Ricky (and others) sometimes seeing a WCS orientation getting flipped.
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.