Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TST: jail export test for markers table #2829

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Apr 24, 2024

Description

This pull request is follow-up of #2755

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Apr 24, 2024
@pllim pllim added bug Something isn't working testing no-changelog-entry-needed changelog bot directive 💤 backport-v3.9.x on-merge: backport to v3.9.x labels Apr 24, 2024
@pllim pllim added this to the 3.9.2 milestone Apr 24, 2024
@pllim pllim added the trivial Only needs one approval instead of two label Apr 24, 2024
@pllim
Copy link
Contributor Author

pllim commented Apr 24, 2024

Hmm looking at the test again, I see this:

    assert "Markers: table" in exp.plugin_table.choices
    exp.filename = str(tmp_path / "cubeviz_export.ecsv")
    exp.plugin_table = "Markers: table"
    exp.export()

But the test creates Markers_table.ecsv in the source directory (where I ran pytest). Is there a bigger bug, @kecnry ?

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kecnry
Copy link
Member

kecnry commented Apr 24, 2024

exp.filename might need to be changed to exp.filename_value after #2824

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (a39a0fe) to head (a14127a).
Report is 13 commits behind head on main.

❗ Current head a14127a differs from pull request most recent head e56dfb3. Consider uploading reports for the commit e56dfb3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2829      +/-   ##
==========================================
+ Coverage   88.88%   88.92%   +0.03%     
==========================================
  Files         111      111              
  Lines       16983    17005      +22     
==========================================
+ Hits        15096    15122      +26     
+ Misses       1887     1883       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim
Copy link
Contributor Author

pllim commented Apr 24, 2024

ValueError: filename_value is not a valid attribute and cannot be set

@kecnry
Copy link
Member

kecnry commented Apr 24, 2024

ok, then this must be the user API, in which case exp.filename.value

markers table export test.
@pllim pllim force-pushed the jail-export-again branch from a14127a to e56dfb3 Compare April 24, 2024 17:10
@pllim pllim enabled auto-merge April 24, 2024 17:12
@pllim pllim merged commit a3b29d3 into spacetelescope:main Apr 24, 2024
14 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Apr 24, 2024
@pllim pllim deleted the jail-export-again branch April 24, 2024 17:31
pllim added a commit that referenced this pull request Apr 24, 2024
…9-on-v3.9.x

Backport PR #2829 on branch v3.9.x (TST: jail export test for markers table)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations testing trivial Only needs one approval instead of two 💤 backport-v3.9.x on-merge: backport to v3.9.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants