-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
TST: jail export test for markers table #2829
Conversation
Hmm looking at the test again, I see this: assert "Markers: table" in exp.plugin_table.choices
exp.filename = str(tmp_path / "cubeviz_export.ecsv")
exp.plugin_table = "Markers: table"
exp.export() But the test creates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2829 +/- ##
==========================================
+ Coverage 88.88% 88.92% +0.03%
==========================================
Files 111 111
Lines 16983 17005 +22
==========================================
+ Hits 15096 15122 +26
+ Misses 1887 1883 -4 ☔ View full report in Codecov by Sentry. |
|
ok, then this must be the user API, in which case |
markers table export test.
a14127a
to
e56dfb3
Compare
…9-on-v3.9.x Backport PR #2829 on branch v3.9.x (TST: jail export test for markers table)
Description
This pull request is follow-up of #2755
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.