Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cubeviz should recognize ERROR and DATA_QUALITY extension names #2840

Merged
merged 1 commit into from
May 1, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented May 1, 2024

Description

I noticed that these extension names were not recognized properly while investigating something else using Cami's private data cube. Might as well add them in?

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 👻

@pllim pllim added the trivial Only needs one approval instead of two label May 1, 2024
@pllim pllim added this to the 3.10 milestone May 1, 2024
@github-actions github-actions bot added cubeviz plugin Label for plugins common to multiple configurations labels May 1, 2024
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.96%. Comparing base (95cf7f2) to head (d6d0cc4).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2840      +/-   ##
==========================================
+ Coverage   88.94%   88.96%   +0.01%     
==========================================
  Files         111      111              
  Lines       17101    17102       +1     
==========================================
+ Hits        15211    15214       +3     
+ Misses       1890     1888       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim merged commit 5d00b97 into spacetelescope:main May 1, 2024
17 of 19 checks passed
@pllim pllim deleted the cubeviz-moar-extnames branch May 1, 2024 17:11
@pllim
Copy link
Contributor Author

pllim commented May 1, 2024

Thanks for the quick approval!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cubeviz plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants