-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
update moment map plugin to use correct display flux units for moment 0 #2877
Conversation
If I create a moment map in the cubeviz example notebook, then convert to Jy/sr and overwrite the first moment map, I still see MJy/sr in the coords display. The moment map plugin itself looks correct and has the correct units, so if updating coords info is out of scope this is looking good! The one maybe bug I found is that when you first open the moment map plugin, there are no output units selected. If you press calculate, however, it still gives you a result. |
I think the unit stuff needed for this won't be released until 4.0, so this probably won't need to be backported or milestoned to 3.10.2 - is that right? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2877 +/- ##
=======================================
Coverage 88.70% 88.70%
=======================================
Files 111 111
Lines 17086 17123 +37
=======================================
+ Hits 15156 15189 +33
- Misses 1930 1934 +4 ☔ View full report in Codecov by Sentry. |
@javerbukh I both of those concerns - the non-selection still allowing you to calculate a MM is now fixed, and the units of the displayed and / or saved MM should reflect the correct display units now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and the points I made earlier have been addressed. Nice work!
994c0ad
to
9d25909
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything tests out and looks good to me!
9d25909
to
4160c62
Compare
thanks for the reviews, i just rebased and ill merge this once tests pass |
This PR updates the moment map plugin to reflect if the current display unit is a Flux or Surface Brightness unit for moment 0 calculations.