-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix Cubeviz movie export #2942
Fix Cubeviz movie export #2942
Conversation
I don't see any |
I added it back in, it probably isn't needed for any of our cases but it's good to have it in to handle some weirder edge cases of what people might input in the field, I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Videos are now downloading with content!
@gibsongreen , is the recording "cutting off" still an issue at all? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
@rosteen , if auto merge fails, take it off auto merge and use your admin power. |
Co-authored-by: Ricky O'Steen <39831871+rosteen@users.noreply.github.com>
@pllim The two issues I had seen was 1, on main that videos were not exporting at all, and 2, after #2896 only blank videos. This was for my local system so maybe cutting off was happening for someone else but this PR enabled the slice range I selected to download as I would expect |
* Remove line relating to Path, filename now normalized to str * Add resolve() call to filename normalization, changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2942 +/- ##
=======================================
Coverage 88.79% 88.79%
=======================================
Files 111 111
Lines 17223 17234 +11
=======================================
+ Hits 15293 15303 +10
- Misses 1930 1931 +1 ☔ View full report in Codecov by Sentry. |
There was a line pertaining to
Path
filenames, but_normalize_filename
now turns everything into a string. Exporting movies works for me now.Not sure what we're milestoning things at at this point...