Markers: Save to CSV #3089
Merged
Markers: Save to CSV #3089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
imviz
plugin
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3089 +/- ##
==========================================
- Coverage 88.76% 88.72% -0.04%
==========================================
Files 111 111
Lines 17246 17257 +11
==========================================
+ Hits 15308 15312 +4
- Misses 1938 1945 +7 ☔ View full report in Codecov by Sentry. |
pllim
requested review from
rosteen,
javerbukh,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
kecnry
reviewed
Jul 16, 2024
pllim
commented
Jul 16, 2024
| @@ -4524,7 +4524,7 @@ def float_precision(column, item): | |||
| # stored in astropy table as a float so we can also store nans, | |||
| # but should display in the UI without any decimals | |||
| return f"{item:.0f}" | |||
| elif column in ('pixel', ): | |||
| elif column in ('pixel', 'pixel_x', 'pixel_y'): | |||
There was a problem hiding this comment.
This mixin is quite generic so I left 'pixel' in, just in case.
kecnry
approved these changes
Jul 18, 2024
Since we do not support reading this back in, I don't see this change being "breaking". |
|
But I wouldn't backport it. |
cshanahan1
approved these changes
Jul 18, 2024
|
@kecnry , are you still concerned about the change log? Any suggestion? |
kecnry
reviewed
Jul 18, 2024
[ci skip] [rtd skip] Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
|
@kecnry , okay, I accepted your suggestion and cleaned it up. Thanks! Okay for my to squash merge when CI passes? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to saving to CSV.
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.