Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Backport PR #3094 on branch v3.10.x (Improve overwrite warning behavior in export) #3100

Conversation

meeseeksmachine
Copy link

Backport PR #3094: Improve overwrite warning behavior in export

@lumberbot-app lumberbot-app bot added this to the 3.10.3 milestone Jul 18, 2024
@lumberbot-app lumberbot-app bot added the bug Something isn't working label Jul 18, 2024
@meeseeksmachine meeseeksmachine requested a review from kecnry as a code owner July 18, 2024 14:44
@lumberbot-app lumberbot-app bot added plugin Label for plugins common to multiple configurations 💤backport-v3.10.x on-merge: backport to v3.10.x labels Jul 18, 2024
@rosteen rosteen merged commit f96b8c0 into spacetelescope:v3.10.x Jul 18, 2024
35 of 36 checks passed
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.88%. Comparing base (f44909e) to head (c3447e8).
Report is 18 commits behind head on v3.10.x.

Files with missing lines Patch % Lines
jdaviz/configs/default/plugins/export/export.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           v3.10.x    #3100      +/-   ##
===========================================
- Coverage    88.90%   88.88%   -0.03%     
===========================================
  Files          111      111              
  Lines        17177    17178       +1     
===========================================
- Hits         15272    15269       -3     
- Misses        1905     1909       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working plugin Label for plugins common to multiple configurations Ready for final review 💤backport-v3.10.x on-merge: backport to v3.10.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants