Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix tray plugin styling #3197

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Sep 16, 2024

Description

This pull request fixes an inadvertent typo introduced in #3137 that resulted in .tray-plugin css styling from being ignored (including hiding the table popout button).

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added UI/UX😍 trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Sep 16, 2024
@kecnry kecnry added this to the 4.0 milestone Sep 16, 2024
@kecnry kecnry marked this pull request as ready for review September 16, 2024 16:45
Copy link
Contributor

@haticekaratay haticekaratay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kecnry kecnry merged commit d49e3b5 into spacetelescope:main Sep 16, 2024
29 checks passed
@kecnry kecnry deleted the tray-plugin-styling-typo branch September 16, 2024 17:06
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.50%. Comparing base (9a85af7) to head (a3ddeff).
Report is 109 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3197   +/-   ##
=======================================
  Coverage   88.50%   88.50%           
=======================================
  Files         124      124           
  Lines       18448    18448           
=======================================
+ Hits        16327    16328    +1     
+ Misses       2121     2120    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants