-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix specviz2d matched mousover marker #3203
Merged
pllim
merged 2 commits into
spacetelescope:main
from
kecnry:fix-specviz2d-mouseover-mark
Oct 1, 2024
Merged
fix specviz2d matched mousover marker #3203
pllim
merged 2 commits into
spacetelescope:main
from
kecnry:fix-specviz2d-mouseover-mark
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
imviz
plugin
Label for plugins common to multiple configurations
labels
Sep 26, 2024
kecnry
requested review from
rosteen,
javerbukh,
pllim,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
September 26, 2024 17:55
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3203 +/- ##
==========================================
+ Coverage 88.50% 88.51% +0.01%
==========================================
Files 124 124
Lines 18579 18580 +1
==========================================
+ Hits 16443 16447 +4
+ Misses 2136 2133 -3 ☔ View full report in Codecov by Sentry. |
Works for me. Thank you for the fix! |
pllim
approved these changes
Oct 1, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/jdaviz
that referenced
this pull request
Oct 1, 2024
pllim
added a commit
that referenced
this pull request
Oct 1, 2024
…3-on-v3.10.x Backport PR #3203 on branch v3.10.x (fix specviz2d matched mousover marker)
rosteen
pushed a commit
to rosteen/jdaviz
that referenced
this pull request
Oct 29, 2024
rosteen
pushed a commit
to rosteen/jdaviz
that referenced
this pull request
Oct 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
imviz
plugin
Label for plugins common to multiple configurations
trivial
Only needs one approval instead of two
💤backport-v3.10.x
on-merge: backport to v3.10.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the visibility of the mouseover marker in the 1d spectrum viewer during a mouseover in the 1d spectrum viewer. This was broken by #2830 which now needs to set
coords_status = True
in cases in which the WCS lookup is successful.Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.