Collapse 3D y before calculating initial model guess for gaussian model #3295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosteen
added
bug
rosteen
requested review from
javerbukh,
pllim,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
github-actions
bot
added
the
plugin
|
Problem solved, thank you! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3295 +/- ##
=======================================
Coverage 88.80% 88.80%
=======================================
Files 125 125
Lines 19009 19011 +2
=======================================
+ Hits 16881 16883 +2
Misses 2128 2128 ☔ View full report in Codecov by Sentry. |
haticekaratay
approved these changes
Nov 15, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/jdaviz
that referenced
this pull request
Nov 15, 2024
…tial model guess for gaussian model
kecnry
pushed a commit
that referenced
this pull request
Nov 15, 2024
…ss for gaussian model (#3297) Co-authored-by: Ricky O'Steen <39831871+rosteen@users.noreply.github.com>
|
Interesting to note that a similar patch was done in the same module in #3190 but in a different class. Hmm. |
|
Yeah, I'm not sure why I didn't think to put it here as well then. |
|
No worries. Looks like test coverage wasn't great either, so not surprised it got through. Just a perfect storm. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a traceback that was occurring when adding a Gaussian model component with
Cube Fittoggled on.