-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
add specviz property to cubeviz/mosviz helpers #330
Conversation
Codecov Report
@@ Coverage Diff @@
## main #330 +/- ##
==========================================
+ Coverage 65.04% 66.05% +1.01%
==========================================
Files 49 47 -2
Lines 2818 2740 -78
==========================================
- Hits 1833 1810 -23
+ Misses 985 930 -55
Continue to review full report at Codecov.
|
After some out-of-band discussion w/ @javerbukh @dtn5ah @rosteen @havok2063 , there's some agreement that this is the way we want to go as an idiom for connecting together "sub-vizes". So I'm converting to "regular" PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely should make a note of this in the docs, and probably add a test for Mosviz and Cubeviz to check that it works (maybe just a call to e.g. viz.specviz.get_spectra()
or something). Do you have bandwidth to make those additions @eteq or should someone else take over?
Edit: I should also note that I tested the actual functionality in Cubeviz and Mosviz and it works in both.
Hmm. I think I have time, but I have said that before and been wrong. Maybe give it another several days, @rosteen, and if I haven't gotten to it by then someone else should jump in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the basic loading sequence and it works. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this, I have a couple docs additions that I'll put in a follow-up PR shortly, rather than adding them here. I'll resolve the merge conflicts here.
Add specviz property to cubeviz/mosviz helpers
aeeb498
to
eba661c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested two blank line addition/deletions to fix codestyle errors.
Add specviz property to cubeviz/mosviz helpers
This implements the feature I suggested in #329. This PR should probably also include some doc updates showing its use a la what @PatrickOgle originally was thinking about in #257 (comment). The idea is that with this you can do something like:
and that should be documented as the intended approach to using specviz helpers in the cubeviz context. But I'm not doing that now because I want to make sure others are ok with this idea before I complete this. Hence the "draft" status.