-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Instructions to install with anaconda navigator #3428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The rendered doc is at https://jdaviz--3428.org.readthedocs.build/en/3428/installation.html
I am not familiar with Navigator. Do we have to provide additional info to steer them away from the default channel (license drama, outdated versions)?
docs/installation.rst
Outdated
@@ -10,8 +10,8 @@ Installation | |||
to the latest version. In general, it is good practice to install the development | |||
version following the instructions below as full released versions may lag behind. | |||
|
|||
User Installation | |||
----------------- | |||
User Installation with conda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think putting conda
in the title here is a little misleading because this section covers installation in general, conda or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I'll revert this. Thanks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3428 +/- ##
=======================================
Coverage 87.53% 87.53%
=======================================
Files 128 128
Lines 19957 19962 +5
=======================================
+ Hits 17469 17474 +5
Misses 2488 2488 ☔ View full report in Codecov by Sentry. |
I am not sure either. As far as I understand, conda-forge is the first channel and default is the second so it should use conda-forge whenever possible. I do not know if there are other implications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clear instructions with screenshots!
I double checked with conda build expert. Indeed, it is not possible to ask conda recipe to pip install, so our dependencies and their dependencies need to be all on conda-forge for jdaviz to be useful on conda-forge. FYI.
Thank you for checking! |
Description
This pull request is to address the lack of instructions to install jdaviz with anaconda navigator.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.