Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove fixed bugs from docs #495

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

javerbukh
Copy link
Contributor

  1. "Specviz Unit Conversion with subset selected" fixed by Unit conversion refactor #360
  2. "Flashing display when data is added or removed too quickly" fixed by Fix GUI update loop #427
  3. "Gaussian smooth crashes after selecting smoothed data in spectrum viewer" fixed by Fix gaussian smooth bug #441

@rosteen and @ibusko , can you check the other bugs listed to see if they are still present? I was not able to replicate the "Cubeviz Collapse and Moment Maps: Spectral bounds do not match Region selection" bug and I have not seen "Ghost subsets and models in spectrum viewer" in a while. "Collapse Plugin spectral bounds don't match selected region" may also be a duplicate of "Cubeviz Collapse...", unless I'm missing something there.

Copy link
Collaborator

@duytnguyendtn duytnguyendtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur with @javerbukh that these bugs, to my knowledge, have been squashed. Thanks for the cleanup, @javerbukh!

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the two Collapse plugin spectral region bugs are subtly different, so I'd leave them both in for now. I also haven't run into the ghosts lately, but I'm ok leaving that in for now as well since I don't remember off the top of my head if something specific was merged that fixed it. Approving.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I should probably select "approve" when approving.

@rosteen rosteen merged commit ef0c012 into spacetelescope:main Apr 2, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants