Fix centroid error in line analysis plugin #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosteen
requested review from
duytnguyendtn,
ibusko and
javerbukh
as code owners
|
Whoa, looks like my local commits are all messed up. I'll have to fix that. (EDIT: fixed) |
ibusko
approved these changes
Apr 14, 2021
|
Merging. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like a numpy update (maybe?) cause the existing syntax (
array is False) to no longer work as it once did, which was causing thecentroidhandling in the line analysis plugin to fail. Switching toarray == 0fixes it.I also fixed a bug I found while testing this that caused
get_subsets_from_viewerto fail if you called the function with adata_labelspecified.