Future-proof physical_type usage for astropy 4.3 #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosteen
requested review from
duytnguyendtn,
ibusko and
javerbukh
as code owners
pllim
reviewed
Apr 21, 2021
| spectral_axis_unit_type = data.spectral_axis.unit.physical_type.title() | ||
| try: | ||
| spectral_axis_unit_type = data.spectral_axis.unit.physical_type.title() | ||
| except AttributeError: |
There was a problem hiding this comment.
except is expensive. Better to check for astropy version on import and use if ... else ... based on that check.
There was a problem hiding this comment.
I also wonder if list(data.spectral_axis.unit.physical_type)[0].title() would be better, in case you are accessing a unit with multiple entries, but if that is not a possibility, then you don't have to.
|
p.s. The protection rule for "outdated branch" might be overkill. Made me press a button that created a merge commit. |
|
Agreed, I was wondering where that came from when I had to do it for one of your PRs. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #549 .