Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: add Voila >= 0.2.8 support #565

Merged

Conversation

mariobuikhuizen
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the embed Regarding issues with front-end embedding label Apr 26, 2021
Copy link
Collaborator

@havok2063 havok2063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably this would also address #552?

Copy link
Contributor

@ibusko ibusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified it works with 0.2.8. It also seems to fix #552

@mariobuikhuizen
Copy link
Collaborator Author

I don't know if it fixes #552, since the reporter of the issue said it was not solved by downgrading Voila to 0.2.7.

@havok2063
Copy link
Collaborator

@mariobuikhuizen sometimes I've found that a voila version alone isn't enough to solve an issue. That we have have to pin specific versions of dependencies, e.g. traitlets or jupyter-server. Could that be an issue in the user's case? What dependency versions should we make sure users have for voila 0.2.7 or above?

@duytnguyendtn duytnguyendtn merged commit ea56f04 into spacetelescope:main May 3, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
embed Regarding issues with front-end embedding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants