Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add --version to CLI #578

Merged
merged 1 commit into from
May 5, 2021
Merged

Add --version to CLI #578

merged 1 commit into from
May 5, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Apr 29, 2021 •
edited
Loading

With this patch, you will see something like this:

$ jdaviz --version
jdaviz, version 1.0.4.dev505+g3568f7c.d20210429

Fix #576 and fix #378

@pllim pllim added the 💤 enhancement New feature or request label Apr 29, 2021
@duytnguyendtn
Copy link
Collaborator

This also may fix #378

@duytnguyendtn duytnguyendtn linked an issue May 3, 2021 that may be closed by this pull request
Request: An easy way to check jdaviz version number #378
Closed
rosteen
rosteen approved these changes May 4, 2021
View reviewed changes
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks.

javerbukh
javerbukh approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@javerbukh javerbukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@javerbukh
Copy link
Contributor

Merging.

@rosteen rosteen merged commit 1e5928d into spacetelescope:main May 5, 2021
@pllim pllim deleted the show-me-the-version branch May 5, 2021 15:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rosteen rosteen rosteen approved these changes

@javerbukh javerbukh javerbukh approved these changes

@duytnguyendtn duytnguyendtn Awaiting requested review from duytnguyendtn

@ibusko ibusko Awaiting requested review from ibusko

Assignees
No one assigned
Labels
💤 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jdaviz --version should show version Request: An easy way to check jdaviz version number
4 participants
@pllim @duytnguyendtn @javerbukh @rosteen