Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TST: Mark test_data_retrieval to require remote_data #580

Merged
merged 1 commit into from
May 5, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Apr 29, 2021

test_data_retrieval in Cubeviz accesses Internet. It should only run in a job that enables --remote-data. Otherwise, you'll hit timeout a lot when all the jobs hit the server at once and you get marked as spammer.

@pllim pllim added testing bug Something isn't working labels Apr 29, 2021
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch.

Copy link
Contributor

@javerbukh javerbukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@javerbukh javerbukh merged commit f07c175 into spacetelescope:main May 5, 2021
@pllim pllim deleted the cubeviz-remote-test branch May 5, 2021 15:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working cubeviz testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants