Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

MNT: Silence tornado warnings #592

Merged
merged 1 commit into from
May 20, 2021
Merged

MNT: Silence tornado warnings #592

merged 1 commit into from
May 20, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented May 6, 2021

Fix #44

Whitelisting alone wasn't enough. Also needed to invoke logger magic.

@pllim pllim requested a review from astrofrog May 6, 2021 19:15
@pllim pllim added the 💤 enhancement New feature or request label May 6, 2021
javerbukh
javerbukh approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@javerbukh javerbukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you had to pull out the wooden stake for this ancient ticket. Nice!

@pllim
Copy link
Contributor Author

pllim commented May 7, 2021

TBH, I don't know if this would mask real security warnings. Someone who knows the implications can comment.

astrofrog
astrofrog approved these changes May 20, 2021
View reviewed changes
Copy link
Collaborator

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable!

@pllim
Copy link
Contributor Author

pllim commented May 20, 2021

Alright then. There are 2 approvals, so I am merging. But if you have second thoughts, feel free to revert.

@pllim pllim merged commit 08ad400 into spacetelescope:main May 20, 2021
@pllim pllim deleted the sharknado-warning-403 branch May 20, 2021 15:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@javerbukh javerbukh javerbukh approved these changes

@astrofrog astrofrog astrofrog approved these changes

@duytnguyendtn duytnguyendtn Awaiting requested review from duytnguyendtn

@ibusko ibusko Awaiting requested review from ibusko

@rosteen rosteen Awaiting requested review from rosteen rosteen is a code owner

Assignees
No one assigned
Labels
Ready for final review 💤 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Whitelisting errors
3 participants
@pllim @astrofrog @javerbukh