-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: also set the height for the app in a lab context #625
Conversation
Who is a heavy Lab user that should review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This edit does allow the app viewer to expand, but I don't see content in it. I tested with Specviz and the content area remained blank even after I loaded a spectrum and some spectral lines. Things work as intended in a regular notebook, so there's still something strange going on with Lab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... Would be nice if @ojustino can also confirm that it works in a clean environment. |
@rosteen , just to be sure, does it still work when you pop it out? |
@pllim I'm a total Lab noob, you're going to need to define what you mean by "pop it out". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rosteen Good call on starting from a clean conda environment. I did that and got the intended results.
Perhaps @pllim was talking about right-clicking the cell containing the app and selecting "Create New View for Output" like we discussed around the time of the JWebbinar? If so, that works for me.
Exactly. Ricky and I resolved that "offline." 😸 |
Thanks, everyone! |
Fixes the missing content in Jupyter Lab: