Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: also set the height for the app in a lab context #625

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

mariobuikhuizen
Copy link
Collaborator

Fixes the missing content in Jupyter Lab:
Screenshot 2021-05-19 at 14 37 47

@github-actions github-actions bot added the embed Regarding issues with front-end embedding label May 19, 2021
@pllim pllim added bug Something isn't working Ready for final review labels May 19, 2021
@pllim
Copy link
Contributor

pllim commented May 21, 2021

Who is a heavy Lab user that should review this?

@rosteen rosteen requested a review from ojustino May 27, 2021 20:22
Copy link
Contributor

@ojustino ojustino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This edit does allow the app viewer to expand, but I don't see content in it. I tested with Specviz and the content area remained blank even after I loaded a spectrum and some spectral lines. Things work as intended in a regular notebook, so there's still something strange going on with Lab.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some Lab issues but was able to resolve them by starting from a clean conda environment and reinstalling everything there. Once I did that I was able to confirm that the app displays properly in Lab, as seen below. Approving.

Screen Shot 2021-06-02 at 11 43 08 AM

@pllim
Copy link
Contributor

pllim commented Jun 2, 2021

Hmm... Would be nice if @ojustino can also confirm that it works in a clean environment.

@pllim
Copy link
Contributor

pllim commented Jun 2, 2021

@rosteen , just to be sure, does it still work when you pop it out?

@rosteen
Copy link
Collaborator

rosteen commented Jun 2, 2021

@pllim I'm a total Lab noob, you're going to need to define what you mean by "pop it out".

@ojustino ojustino self-requested a review June 2, 2021 16:15
Copy link
Contributor

@ojustino ojustino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rosteen Good call on starting from a clean conda environment. I did that and got the intended results.

Perhaps @pllim was talking about right-clicking the cell containing the app and selecting "Create New View for Output" like we discussed around the time of the JWebbinar? If so, that works for me.

@pllim
Copy link
Contributor

pllim commented Jun 2, 2021

Create New View for Output

Exactly. Ricky and I resolved that "offline." 😸

@pllim pllim merged commit c36c82d into spacetelescope:main Jun 2, 2021
@pllim
Copy link
Contributor

pllim commented Jun 2, 2021

Thanks, everyone!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working embed Regarding issues with front-end embedding Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants