Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MNT: Bump glue-jupyter minversion to 0.6.1 #678

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jun 10, 2021

Fix #660

Fix #677

This is #664 with upstream fix.

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #678 (ecdd4fa) into main (e0efb4f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #678   +/-   ##
=======================================
  Coverage   59.60%   59.60%           
=======================================
  Files          65       65           
  Lines        4005     4005           
=======================================
  Hits         2387     2387           
  Misses       1618     1618           
Impacted Files Coverage Δ
jdaviz/configs/imviz/plugins/tools.py 38.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0efb4f...ecdd4fa. Read the comment docs.

Copy link
Contributor

@javerbukh javerbukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that I can make regions in image viewers again, approving.

@rosteen rosteen merged commit 664d35b into spacetelescope:main Jun 10, 2021
@pllim pllim deleted the bump-gluj-0.6.1 branch June 10, 2021 17:06
@@ -30,7 +30,7 @@ def activate(self):
@viewer_tool
class BqplotMatchWCS(BqplotPanZoomMode):

icon = os.path.join(ICON_DIR, 'pan_wcs.png')
icon = os.path.join(ICON_DIR, 'pan_wcs.svg')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the PNG file from the repo too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #679

@pllim pllim mentioned this pull request Jun 10, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
4 participants