Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MNT: Bump ipyvuetify for lab dark mode #684

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jun 16, 2021

Fix #665

As advised by @mariobuikhuizen in #682 (comment)

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #684 (7b8bab6) into main (664d35b) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #684      +/-   ##
==========================================
- Coverage   59.75%   59.60%   -0.15%     
==========================================
  Files          65       65              
  Lines        4005     4005              
==========================================
- Hits         2393     2387       -6     
- Misses       1612     1618       +6     
Impacted Files Coverage Δ
...configs/default/plugins/data_tools/file_chooser.py 65.71% <0.00%> (-3.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 664d35b...7b8bab6. Read the comment docs.

@rosteen rosteen merged commit 4086e64 into spacetelescope:main Jun 21, 2021
@rosteen
Copy link
Collaborator

rosteen commented Jun 21, 2021

I think this falls under the "small thing for which one review is ok" category, merged.

@pllim pllim deleted the bump-ipyvuetify branch June 21, 2021 13:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jdaviz is hard-to-read and partly broken in Jupyterlab dark mode
2 participants