Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Always jump to create new subset #708

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Always jump to create new subset #708

merged 1 commit into from
Jul 6, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jul 1, 2021 •
edited
Loading

@pllim pllim added the imviz label Jul 1, 2021
@pllim pllim added this to the Imviz 1.0 milestone Jul 1, 2021
@github-actions github-actions bot removed the imviz label Jul 1, 2021
@pllim pllim requested a review from astrofrog July 1, 2021 16:24
@pllim

This comment has been minimized.

# to view
@pllim pllim force-pushed the always-create-new branch from f982b41 to bf786a1 Compare July 2, 2021 15:43
@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #708 (bf786a1) into main (9ce4a91) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
+ Coverage   61.05%   61.19%   +0.14%     
==========================================
  Files          65       65              
  Lines        4157     4157              
==========================================
+ Hits         2538     2544       +6     
+ Misses       1619     1613       -6
Impacted Files Coverage Δ
jdaviz/app.py 78.94% <100.00%> (ø)
...configs/default/plugins/data_tools/file_chooser.py 69.14% <0.00%> (+3.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce4a91...bf786a1. Read the comment docs.

@rosteen rosteen requested a review from PatrickOgle July 6, 2021 14:50
@rosteen
Copy link
Collaborator

rosteen commented Jul 6, 2021

@pllim I'd like approval from the PO (I think @PatrickOgle ) who requested this that the functionality meets their expectations. Maybe you can demo it in our meeting this morning and I'll sign off and merge after.

rosteen
rosteen approved these changes Jul 6, 2021
View reviewed changes
Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with a demo offline that this is working as desired, approving.

@rosteen rosteen merged commit 409587a into spacetelescope:main Jul 6, 2021
@pllim pllim deleted the always-create-new branch July 6, 2021 15:37
@pllim pllim mentioned this pull request Aug 25, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rosteen rosteen rosteen approved these changes

@astrofrog astrofrog astrofrog approved these changes

@duytnguyendtn duytnguyendtn Awaiting requested review from duytnguyendtn

@ibusko ibusko Awaiting requested review from ibusko

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh is a code owner

@PatrickOgle PatrickOgle Awaiting requested review from PatrickOgle

Assignees
No one assigned
Labels
imviz Ready for final review
Projects
None yet
Milestone
Imviz 1.0
Development

Successfully merging this pull request may close these issues.

JDAT-1483: Imviz region support: Should not have to click "Create new" to create new regions
3 participants
@pllim @rosteen @astrofrog