-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Imviz regions setter/getter API #721
Conversation
Codecov Report
@@ Coverage Diff @@
## main #721 +/- ##
==========================================
+ Coverage 62.40% 62.52% +0.12%
==========================================
Files 65 65
Lines 4237 4267 +30
==========================================
+ Hits 2644 2668 +24
- Misses 1593 1599 +6
Continue to review full report at Codecov.
|
So, using "reference data" got around the problem I encountered in #630 . 😸 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I tested the code in the example notebook and it works. The API makes sense to me. I noted some performance issues in #723, I don't think they need to hold up this ticket but should be a priority to fix, in my opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I tested with the example notebook and it works as expected.
e358949
to
650d13c
Compare
Given there are 2 approvals, I am merging. Thanks, everyone! p.s. I ran it locally after rebase and nothing broke. The lag is very apparent but out of scope, as Ricky said. |
Fix #622. Second attempt of #630. (It is easier to open a new PR than to resolve conflicts of that one...)
Note to self: Open follow-up issues about modifying regions, roundtripping, GWCS support...