Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clarify tooltip for WCS panzoom tool #749

Merged
merged 2 commits into from
Aug 2, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jul 27, 2021

Based on Imviz Hack Hour feedback. This goes with glue-viz/glue-jupyter#245

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #749 (b11650a) into main (e29b827) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #749      +/-   ##
==========================================
- Coverage   63.00%   62.84%   -0.17%     
==========================================
  Files          65       65              
  Lines        4290     4290              
==========================================
- Hits         2703     2696       -7     
- Misses       1587     1594       +7     
Impacted Files Coverage Δ
jdaviz/configs/imviz/plugins/tools.py 37.62% <100.00%> (ø)
...configs/default/plugins/data_tools/file_chooser.py 65.71% <0.00%> (-3.43%) ⬇️
jdaviz/configs/imviz/helper.py 98.49% <0.00%> (-0.51%) ⬇️
jdaviz/configs/specviz/plugins/viewers.py 60.94% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e29b827...b11650a. Read the comment docs.

Copy link
Contributor

@camipacifici camipacifici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with the change. Thank you!

@rosteen rosteen merged commit bf6d52b into spacetelescope:main Aug 2, 2021
@pllim pllim deleted the zoom-icon-tooltip branch August 2, 2021 14:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants