Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MNT: Bump glue-astronomy minversion to 0.2 #787

Merged
merged 1 commit into from
Aug 15, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Aug 14, 2021

Description

This pull request is to bump minversion of glue-astronomy from dev hash to 0.2 release. This is needed for #706.

Fixes #711

Also see glue-viz/glue-astronomy#37

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #787 (6157649) into main (a8c6ede) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #787   +/-   ##
=======================================
  Coverage   64.37%   64.37%           
=======================================
  Files          65       65           
  Lines        4348     4348           
=======================================
  Hits         2799     2799           
  Misses       1549     1549           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8c6ede...6157649. Read the comment docs.

@pllim pllim added the trivial Only needs one approval instead of two label Aug 15, 2021
@pllim pllim merged commit 519aaec into spacetelescope:main Aug 15, 2021
@pllim pllim deleted the bump-glue-astronomy-0.2 branch August 15, 2021 04:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
imviz Ready for final review trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MNT: Pin glue-astronomy back to stable after 0.2 release on PyPI
2 participants