-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
viewer toolbar: align to right #901
Conversation
* v-toolbar: apply inline css to align right (with 2px padding), removed right property which, as far as I can tell from testing and the vue API docs, does nothing. * child save v-menu: align left so doesn't overflow into the next viewer (since the parent button is now on the far right)
Codecov Report
@@ Coverage Diff @@
## main #901 +/- ##
=======================================
Coverage 68.38% 68.38%
=======================================
Files 66 66
Lines 4799 4799
=======================================
Hits 3282 3282
Misses 1517 1517 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The menu with "save as png" and "save as svg" that pops up if you click on the save icon. It used to extend to the right of the save icon, but that would now overflow past the edge of the viewer (if there are multiple viewers like in Cubeviz). I changed that to always extend to the left so it doesn't overflow. |
Ah! I obviously never try to click that button. 😆 Looks nice. Would approve again! -- ⭐⭐⭐⭐⭐ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change, thank you!
Description
This pull request moves the alignment of the "hammer and screwdriver" toolbar to the right and the child "save" menu to the left so it does not overflow past the far right of the viewer.
Fixes #659
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.CHANGES.rst
?