Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

wrap tab items in lazy component to fix initial tab selection #924

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Oct 7, 2021

Description

This pull request fixes the lack of an initial tab underline on the slider of the viewer/layer menu, by wrapping with a v-lazy component, because that makes perfect sense.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added the no-changelog-entry-needed changelog bot directive label Oct 7, 2021
@kecnry kecnry added this to the 2.1 milestone Oct 7, 2021
@github-actions github-actions bot added the embed Regarding issues with front-end embedding label Oct 7, 2021
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #924 (2fdad54) into main (743e656) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #924   +/-   ##
=======================================
  Coverage   69.24%   69.24%           
=======================================
  Files          68       68           
  Lines        4832     4832           
=======================================
  Hits         3346     3346           
  Misses       1486     1486           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 743e656...2fdad54. Read the comment docs.

Copy link
Contributor

@javerbukh javerbukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯 Nice work!

Copy link
Contributor

@ojustino ojustino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good, subtle change. I'm attaching before and after screenshots for posterity's sake.

image
image

@rosteen
Copy link
Collaborator

rosteen commented Oct 8, 2021

Thanks for the screenshots @ojustino , I was wondering what the difference was from reading the description but was being too v-lazy myself to check.

@rosteen rosteen merged commit a792f8c into spacetelescope:main Oct 8, 2021
@kecnry kecnry deleted the tab-initial-slider-underline branch October 8, 2021 19:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
embed Regarding issues with front-end embedding no-changelog-entry-needed changelog bot directive Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants