Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix plugin description text color in dark theme #937

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Oct 15, 2021

Description

This pull request fixes the text color of the plugin descriptions to be dark-theme-friendly.

Fixes #933

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added the no-changelog-entry-needed changelog bot directive label Oct 15, 2021
@kecnry kecnry added this to the 2.1 milestone Oct 15, 2021
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #937 (91967bc) into main (4c2c3a5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #937   +/-   ##
=======================================
  Coverage   69.37%   69.37%           
=======================================
  Files          69       69           
  Lines        4888     4888           
=======================================
  Hits         3391     3391           
  Misses       1497     1497           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b01d538...91967bc. Read the comment docs.

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! Maybe another dev wanna double check on a different setting/machine as well.

Screenshot 2021-10-15 102423

@pllim pllim added bug Something isn't working Ready for final review labels Oct 15, 2021
Copy link
Contributor

@ojustino ojustino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change works for me, too.

image

@pllim pllim merged commit cef2789 into spacetelescope:main Oct 15, 2021
@kecnry kecnry deleted the plugin-description-dark branch October 15, 2021 15:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working no-changelog-entry-needed changelog bot directive Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip hard to read in Lab dark mode
3 participants