Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MNT: Remove unused AddViewerMessage #939

Merged
merged 1 commit into from
Oct 18, 2021
Merged

MNT: Remove unused AddViewerMessage #939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ Specviz
API Changes
-----------

- Removed unused ``jdaviz.core.events.AddViewerMessage``. [#939]

Cubeviz
^^^^^^^

Expand Down
13 changes: 1 addition & 12 deletions jdaviz/core/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from glue.core.message import Message

__all__ = ['NewViewerMessage', 'AddViewerMessage', 'LoadDataMessage',
__all__ = ['NewViewerMessage', 'LoadDataMessage',
'AddDataMessage', 'SnackbarMessage', 'RemoveDataMessage',
'AddLineListMessage', 'TableClickMessage']

Expand All @@ -26,17 +26,6 @@ def x_attr(self):
return self._x_attr


class AddViewerMessage(Message):
def __init__(self, viewer, *args, **kwargs):
super().__init__(*args, **kwargs)

self._viewer = viewer

@property
def viewer(self):
return self._viewer


class LoadDataMessage(Message):
def __init__(self, path, *args, **kwargs):
super().__init__(*args, **kwargs)
Expand Down
2 changes: 1 addition & 1 deletion notebooks/concepts/concept_programmatic_viewers_from_blank_default.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@
"# app.create_viewer('image-viewer') or app.create_viewer('Image 2D')\n",
"\n",
"# hack to create a new viewer programmatically using code from the Viewer Creator plugin\n",
"from jdaviz.core.events import NewViewerMessage, AddViewerMessage\n",
"from jdaviz.core.events import NewViewerMessage\n",
"viewer_cls = viewer_registry.members['g-image-viewer']['cls']\n",
"new_viewer_message = NewViewerMessage(viewer_cls, data=None, sender=app)\n",
"app.hub.broadcast(new_viewer_message)"
Expand Down