Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Toolbar dividers #944

Merged
merged 3 commits into from
Oct 20, 2021
Merged

Toolbar dividers #944

merged 3 commits into from
Oct 20, 2021

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Oct 20, 2021

Description

This pull request adds vertical dividers and padding to the app toolbar to clearly differentiate between different "tools" (and as a bonus, fixes the layout of the redshift select element to be vertically centered). Some vertical dividers already existed, but they were applied inconsistently. See before and after screenshots below.

Before:
Screen Shot 2021-10-20 at 8 55 43 AM

Screen Shot 2021-10-20 at 8 54 56 AM

After:
Screen Shot 2021-10-20 at 8 55 21 AM

Screen Shot 2021-10-20 at 8 54 17 AM

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a change log needed? If yes, is it added to CHANGES.rst?
  • Is a milestone set? Milestone is only currently required for PRs related to Imviz MVP.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added UI/UX😍 no-changelog-entry-needed changelog bot directive labels Oct 20, 2021
@kecnry kecnry added this to the 2.1 milestone Oct 20, 2021
@github-actions github-actions bot added embed Regarding issues with front-end embedding specviz labels Oct 20, 2021
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #944 (1366710) into main (3dbc20f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #944   +/-   ##
=======================================
  Coverage   69.40%   69.40%           
=======================================
  Files          69       69           
  Lines        4880     4880           
=======================================
  Hits         3387     3387           
  Misses       1493     1493           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dbc20f...1366710. Read the comment docs.

@pllim
Copy link
Contributor

pllim commented Oct 20, 2021

I pinged PO on Slack to review this. FYI.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@PatrickOgle PatrickOgle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. Thanks.

@rosteen rosteen merged commit 2695dca into spacetelescope:main Oct 20, 2021
@kecnry kecnry deleted the toolbar-dividers branch October 20, 2021 13:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
embed Regarding issues with front-end embedding no-changelog-entry-needed changelog bot directive specviz UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants