-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Toolbar dividers #944
Toolbar dividers #944
Conversation
(and small tweak to vertical alignment by hiding textless hint under select UI element)
Codecov Report
@@ Coverage Diff @@
## main #944 +/- ##
=======================================
Coverage 69.40% 69.40%
=======================================
Files 69 69
Lines 4880 4880
=======================================
Hits 3387 3387
Misses 1493 1493 Continue to review full report at Codecov.
|
I pinged PO on Slack to review this. FYI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good. Thanks.
Description
This pull request adds vertical dividers and padding to the app toolbar to clearly differentiate between different "tools" (and as a bonus, fixes the layout of the redshift select element to be vertically centered). Some vertical dividers already existed, but they were applied inconsistently. See before and after screenshots below.
Before:
After:
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.CHANGES.rst
?