Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix error trace introduced to Specviz model fitting #970

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

rosteen
Copy link
Collaborator

@rosteen rosteen commented Nov 17, 2021

Description

Fixes an error trace when selected a subset in the model fitting plugin in Specviz, introduced in #951 due to a last minute change putting code back in for Cubeviz.

@rosteen rosteen added bug Something isn't working trivial Only needs one approval instead of two labels Nov 17, 2021
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #970 (fb1d327) into main (987f797) will increase coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #970      +/-   ##
==========================================
+ Coverage   69.30%   69.41%   +0.10%     
==========================================
  Files          69       69              
  Lines        4946     4947       +1     
==========================================
+ Hits         3428     3434       +6     
+ Misses       1518     1513       -5     
Impacted Files Coverage Δ
...igs/default/plugins/model_fitting/model_fitting.py 29.29% <0.00%> (-0.10%) ⬇️
...configs/default/plugins/data_tools/file_chooser.py 69.14% <0.00%> (+3.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 987f797...fb1d327. Read the comment docs.

@pllim pllim added the specviz label Nov 17, 2021
@pllim pllim added this to the 2.1 milestone Nov 17, 2021
@pllim pllim added the no-changelog-entry-needed changelog bot directive label Nov 17, 2021
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: This affects unreleased version, so no need for change log.

Seems uncontroversial enough. Let's get this in!

@pllim pllim merged commit c374fcf into spacetelescope:main Nov 17, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working no-changelog-entry-needed changelog bot directive specviz trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants