-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
redshift slider select wide enough to avoid overflow #989
Conversation
Codecov Report
@@ Coverage Diff @@
## main #989 +/- ##
==========================================
- Coverage 70.64% 70.53% -0.12%
==========================================
Files 74 74
Lines 5437 5437
==========================================
- Hits 3841 3835 -6
- Misses 1596 1602 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Somehow I never thought to change this despite it bugging me.
* dynamic width could be an option down the road, but will need to be clever to avoid jittering and encroaching on the slider too much
* hooks into the @change signal and strips any non-numeric characters from the input string * using type="number" is another option, but adds arrow buttons which are difficult to hide and take up precious space
Updated the PR to also set a min-width on the text input with room for 6 digits (and while I was at it, I fixed the text-input to not crash when putting in non-numeric characters). We may want to consider a dynamic width at some point, but that proved to be a bit tricky to avoid jittering and encroaching on the space of the slider itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in. Thanks!
Description
This pull request fixes a minor annoyance in the width of the select element (between redshift and RV) in the specviz redshift slider. See before and after screenshots below.
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.CHANGES.rst
?