-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
jdaviz 3.9 updates #68
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kecnry
added
the
waiting-on-jdaviz-release
PR requires a release from jdaviz before updating the pin
label
Dec 1, 2023
This was referenced Mar 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 93.92% 94.50% +0.57%
==========================================
Files 37 37
Lines 1598 1582 -16
==========================================
- Hits 1501 1495 -6
+ Misses 97 87 -10 ☔ View full report in Codecov by Sentry. |
(but leave infrastructure in place for now)
if spacetelescope/jdaviz#2742 is merged, we should include this to avoid opening the data menu when creating populated phase viewers
kecnry
commented
Apr 5, 2024
kecnry
removed
the
waiting-on-jdaviz-release
PR requires a release from jdaviz before updating the pin
label
Apr 5, 2024
bmorris3
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go when tests pass.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR encompasses minor updates for when we want to update the min-pin on jdaviz to 3.9
Waiting for:
jdaviz 3.9Will also get from upstream:
TODO: