Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Change CDBS to TRDS #278

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Change CDBS to TRDS #278

merged 1 commit into from
Jul 29, 2020

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jul 21, 2020 •
edited
Loading

Address the code changes for #270

Companion to spacetelescope/stsynphot_refactor#121 and spacetelescope/pysynphot#135

@pllim pllim added this to the 1.0.0 milestone Jul 21, 2020
This was referenced Jul 21, 2020
Closed
Merged
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #278 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #278   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files          16       16           
  Lines        2005     2005           
=======================================
  Hits         1893     1893           
  Misses        112      112
Impacted Files Coverage Δ
synphot/config.py 100.00% <ø> (ø)
synphot/utils.py 98.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5c997e...b209cc7. Read the comment docs.

@pllim pllim mentioned this pull request Jul 22, 2020
Merged
@pllim pllim changed the title Replace CDBS with TRDS Change CDBS to TRDS Jul 22, 2020
ariedel
ariedel approved these changes Jul 22, 2020
View reviewed changes
Copy link

@ariedel ariedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@pllim pllim merged commit 68c55ea into spacetelescope:master Jul 29, 2020
@pllim pllim deleted the redcat-trds branch July 29, 2020 21:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ariedel ariedel ariedel approved these changes

Assignees
No one assigned
Labels
Upstream changes
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pllim @ariedel