Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove pytest-openfiles, fix unit string comparison in doctests #350

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Mar 14, 2023

and rely on ResourceWarning instead
that affected by new unit string ordering.
@github-actions
Copy link

github-actions bot commented Mar 14, 2023

Thank you for your contribution! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the STScI coding guidelines?
  • Are tests added/updated as required? If so, do they follow the STScI testing guidelines?
  • Are docs added/updated as required?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6c2bd36) 97.09% compared to head (e50ef21) 97.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #350   +/-   ##
=======================================
  Coverage   97.09%   97.09%           
=======================================
  Files          17       17           
  Lines        2030     2032    +2     
=======================================
+ Hits         1971     1973    +2     
  Misses         59       59           
Impacted Files Coverage Δ
synphot/blackbody.py 73.33% <100.00%> (+0.45%) ⬆️
synphot/specio.py 99.09% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pllim pllim merged commit 2e9032f into spacetelescope:master Mar 14, 2023
@pllim pllim deleted the fix-ci-20230314 branch March 14, 2023 14:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ANN: Please migrate away from pytest-openfiles
1 participant