Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

openPMD-api: CTest & Install Tests #25300

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Aug 6, 2021

Run CTest at build time with:

spack install --test=root openpmd-api@<version>

Ref.: https://spack.readthedocs.io/en/latest/packaging_guide.html#stand-alone-or-smoke-tests

Run smoke-tests after install and loading of the package via

spack load -r /<spec>
spack test run /<spec>

x-ref: https://github.com/buildtesters/buildtest-cori/issues/56

@ax3l ax3l added tests General test capability(ies) ecp e4s labels Aug 6, 2021
@ax3l ax3l requested a review from shahzebsiddiqui August 6, 2021 23:02
@spackbot-app spackbot-app bot added stand-alone-tests Stand-alone (or smoke) tests for installed packages update-package labels Aug 6, 2021
Run CTest at build time with:
```
spack install --test=root openpmd-api@<version>
```

and run smoke-tests after install and loading of the package via
```
spack load -r /<spec>
spack test run /<spec>
```
@ax3l ax3l force-pushed the openpmd-api-tests branch from 3c22033 to 836d611 Compare August 6, 2021 23:14
@ax3l ax3l enabled auto-merge (squash) August 6, 2021 23:14
@ax3l ax3l removed the request for review from shahzebsiddiqui August 6, 2021 23:21
@shahzebsiddiqui
Copy link
Contributor

@tldahlgren can you please backport this to e4s branch we need this test

@ax3l ax3l merged commit 98d4a7a into spack:develop Aug 6, 2021
@ax3l ax3l deleted the openpmd-api-tests branch August 7, 2021 00:30
@tldahlgren
Copy link
Contributor

@ax3l What was the problem you were having that cause you to need to load the module first?

@ax3l
Copy link
Member Author

ax3l commented Aug 11, 2021

@tldahlgren spack test run /<spec> would not find the executable otherwise that I am testing.

for exe in exes:
spec_vers_str = '{0}'.format(self.spec.version)
reason = 'test version of {0} is {1}'.format(exe, spec_vers_str)
self.run_test(exe, ['--version'], [spec_vers_str],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tldahlgren this line essentially does not work if not loaded

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's something in the process that I'm missing that I need to look into. Thanks.

@tgamblin
Copy link
Member

@shahzebsiddiqui can you please submit a PR backporting this to the E4S branch?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
e4s ecp stand-alone-tests Stand-alone (or smoke) tests for installed packages tests General test capability(ies) update-package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants