fix: XML::Reader#attribute_hash returns nil on error #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
flavorjones-fix-reader-error-handling_v1.13.x
branch
from
3375c1f to
f9d9061
Compare
Note that on JRuby, the namespaces are still returned because the parse error would raised on the subsequent node expansion. This restores the behavior from v1.13.7
flavorjones
force-pushed
the
flavorjones-fix-reader-error-handling_v1.13.x
branch
from
f9d9061 to
9fe0761
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Reader#attribute_hashdoes not behave the same wayReader#attribute_nodesbehaved when parse errors are encountered.For callers of
Reader#attributesthis restores the behavior from v1.13.7 before #2602.See also the related change in #2714 which will land in v1.14.0 that raises a
SyntaxErrorinstead of returningnil.Have you included adequate test coverage?
Yes, coverage added.
Does this change affect the behavior of either the C or the Java implementations?
The C and Java parsers differ in when they detect a syntax error in this case. libxml2 indicates an error when we try to expand a start tag that does not have a matching end tag, but xerces will defer the error until later. The tests reflect that difference.